Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly normalize relative paths for 'pip show' #10206

Merged
merged 4 commits into from
Jul 31, 2021

Commits on Jul 26, 2021

  1. Test the file entries are correct

    This is passing against 21.1.3, but not main. The installed-files.txt
    test case is substentially rewritten to correctly test against a legacy
    setuptools installation.
    uranusjr committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    e1ccc43 View commit details
    Browse the repository at this point in the history
  2. Correctly normalize paths relative to install path

    Since the legacy installed-files.txt writes paths relatively to the
    egg-info directory, we need to introduce a new property on
    BaseDistribution to return that directory's path (analoguous to
    pkg_resources's Distribution.egg_info).
    
    Entries in RECORD are normalized with pathlib.Path so they have the
    correct path component separator depending on the platform (e.g. '/' on
    Windows), to match the previous behavior.
    uranusjr committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    d0ce82a View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Configuration menu
    Copy the full SHA
    dd8a117 View commit details
    Browse the repository at this point in the history
  2. More complicated conversion

    uranusjr committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    3bf6c7c View commit details
    Browse the repository at this point in the history