Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration: Add back load_file verbose log instead of debug one #10418

Merged
merged 1 commit into from Sep 20, 2021
Merged

configuration: Add back load_file verbose log instead of debug one #10418

merged 1 commit into from Sep 20, 2021

Conversation

NoahGorny
Copy link
Contributor

Closes #10268

@NoahGorny NoahGorny force-pushed the config-add-back-verbose-output branch from 0d672d7 to cc41b1e Compare August 31, 2021 20:47
@uranusjr
Copy link
Member

uranusjr commented Sep 4, 2021

Linter is failing.

@NoahGorny NoahGorny force-pushed the config-add-back-verbose-output branch from cc41b1e to 2570d4a Compare September 7, 2021 07:02
@NoahGorny
Copy link
Contributor Author

fixed the linting problem 😄

@uranusjr
Copy link
Member

uranusjr commented Sep 7, 2021

Now tests are failing! I suspect it’s because this emit a message at a slightly higher level than previously expected?

@NoahGorny
Copy link
Contributor Author

Now tests are failing! I suspect it’s because this emit a message at a slightly higher level than previously expected?

The test that fail is tests/functional/test_install_reqs.py::test_relative_requirements_file[rel_url-False] which seems to fail on the main branch as well (something about a warning of a broken package)

So it does not seem to be related to this PR

@NoahGorny
Copy link
Contributor Author

I think its ready to be merged, what do you guys think? @uranusjr @pradyunsg

@uranusjr uranusjr merged commit 108af9e into pypa:main Sep 20, 2021
@NoahGorny NoahGorny deleted the config-add-back-verbose-output branch September 21, 2021 06:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip config list -v
3 participants
@NoahGorny @uranusjr @pradyunsg