Complete type hints of tests/unit/ directory

[jdufresne]

Adding these types exposed some tests that were passing invalid values
to functions.

These types also allowed refining some existing APIs.

[uranusjr]

I did not read all the type hint additions in the test suite, but assume they are fine since Mypy is passing. The type hint changes in pip proper are all correct.

[jdufresne]

I did not read all the type hint additions in the test suite, but assume they are fine since Mypy is passing.

If you'd like me to break this down to multiple PRs to assist review, please let me know. I can either chunk it to fewer file changes at a time or if you notice standalone changes I can tease those out. If that is desirable, please let me know, it is no problem.

[pradyunsg]

Suggested change

	def raise_broken_stdout() -> int:
	def raise_broken_stdout() -> NoReturn:

[pradyunsg]

I'm at 44/64, and this looks pretty good! :)

[pradyunsg]

Suggested change

	entry = wc.get_cache_entry(persi_link, "persi", supported_tags)
	assert entry is not None
	assert entry.persistent
	entry = wc.get_cache_entry(ephem_link, "ephem", supported_tags)
	assert entry is not None
	assert not entry.persistent
	assert wc.get_cache_entry(other_link, "other", supported_tags) is None
	entry = wc.get_cache_entry(persi_link, "persi", supported_tags)
	assert entry is not None
	assert entry.persistent
	entry = wc.get_cache_entry(ephem_link, "ephem", supported_tags)
	assert entry is not None
	assert not entry.persistent
	assert wc.get_cache_entry(other_link, "other", supported_tags) is None

I like whitespace.

[pradyunsg]

Suggested change

	metadata = email.message.Message()
	metadata["name"] = "simplewheel"
	metadata["version"] = "1.0"
	req._metadata = metadata
	req.assert_source_matches_version()
	metadata = email.message.Message()
	metadata["name"] = "simplewheel"
	metadata["version"] = "1.0"
	req._metadata = metadata
	req.assert_source_matches_version()

As I was saying, I like my whitespace.

[jdufresne]

Thanks for the review. I applied all suggestions in the latest revision.

[pradyunsg]

FWIW, for large PRs like this, I'd encourage you to make commit --fixup for changes and doing a single rebase --autosquash once approved, prior to merging. It makes reviewing the actual changes easier. :)

[pradyunsg]

Alrighty. GitHub says I've looked at each file and marked it as viewed. :)