Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Development Getting Started guide to reflect reality #10449

Merged
merged 2 commits into from Nov 7, 2021

Conversation

pradyunsg
Copy link
Member

  • The VCS tests are automatically skipped. The phrasing in the guide
    stated otherwise.
  • Recommend using .venv as the folder name for the virtual environment
    for development.

Related to #10443

- The VCS tests are automatically skipped. The phrasing in the guide
  stated otherwise.
- Recommend using `.venv` as the folder name for the virtual environment
  for development.
@pradyunsg pradyunsg added type: docs Documentation related skip news Does not need a NEWS file entry (eg: trivial changes) labels Sep 8, 2021
@notatallshaw
Copy link
Contributor

notatallshaw commented Sep 13, 2021

As per my comment here: #10443 (comment)

It seems on Windows there must be some python (not just py) on the PATH outside the virtual environment. Probably because of this bug: https://bugs.python.org/issue38905

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Sep 29, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Nov 5, 2021
@pradyunsg
Copy link
Member Author

pradyunsg commented Nov 7, 2021

Merging this, since it's accurate on its own. The windows-specific nuances are being discussed in #10443.

@pradyunsg pradyunsg merged commit d81c65a into pypa:main Nov 7, 2021
@pradyunsg pradyunsg deleted the tweak-dev-getting-started branch November 7, 2021 09:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants