Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "session" fixtures in tests/unit/test_req_file.py #10494

Merged
merged 1 commit into from Sep 21, 2021
Merged

Add missing "session" fixtures in tests/unit/test_req_file.py #10494

merged 1 commit into from Sep 21, 2021

Conversation

jdufresne
Copy link
Contributor

Caught by mypy:

tests/unit/test_req_file.py:342: error: Argument "session" to "parse_reqfile"
has incompatible type "Callable[[], PipSession]"; expected "PipSession"
[arg-type]
    ...  reqs = list(parse_reqfile("./parent/req_file.txt", session=session))
                                                                    ^

Caught by mypy:

    tests/unit/test_req_file.py:342: error: Argument "session" to "parse_reqfile"
    has incompatible type "Callable[[], PipSession]"; expected "PipSession"
    [arg-type]
        ...  reqs = list(parse_reqfile("./parent/req_file.txt", session=session))
                                                                        ^
@uranusjr uranusjr merged commit a902f5c into pypa:main Sep 21, 2021
@jdufresne jdufresne deleted the missing-session branch September 30, 2021 11:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants