Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the appropriate documentation in pip backtracking output #10516

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Add link to the appropriate documentation in pip backtracking output #10516

merged 3 commits into from
Oct 2, 2021

Conversation

ziebam
Copy link
Contributor

@ziebam ziebam commented Sep 28, 2021

I didn't add a news entry since I don't think the change is significant enough.

Closes #9255.

After consideration I included the `# noqa: E501` comment to retain
readability since the URL is pretty verbose.
@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 1, 2021
@uranusjr uranusjr added this to the 21.3 milestone Oct 1, 2021
The user should choose to abort the run -- we don't want to imply that
they need to do so.
@ziebam
Copy link
Contributor Author

ziebam commented Oct 2, 2021

Thanks for the review and the changes @pradyunsg! Looks like the failing tests might be related to #10495? Not sure though...

@pradyunsg
Copy link
Member

Yea, #10532 will fix that. :)

@pradyunsg pradyunsg merged commit e1dd4b4 into pypa:main Oct 2, 2021
@ziebam ziebam deleted the iss9255-include-backtracking-docs-in-backtracking-output branch October 2, 2021 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip backtracking output to link to "reduce backtracking" doc
4 participants