Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renamed author #10673

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix renamed author #10673

merged 2 commits into from
Nov 23, 2021

Conversation

ofek
Copy link
Sponsor Contributor

@ofek ofek commented Nov 22, 2021

That was from my email and old GitHub name before renaming the account, I'll just use my name now instead

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Nov 22, 2021
@pradyunsg
Copy link
Member

You're gonna need to update .mailmap instead.

@uranusjr
Copy link
Member

I believe we need an entry in .mailmap as well to avoid this being overwritten by the automation tool.

@pradyunsg
Copy link
Member

See https://github.com/pypa/pip/pull/10592/files and corresponding issue.

pradyunsg
pradyunsg requested changes Nov 22, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted above.

@ofek
Copy link
Sponsor Contributor Author

ofek commented Nov 22, 2021

Did I do that correctly?

pradyunsg
pradyunsg approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and confirmed that this works!

@pradyunsg pradyunsg merged commit 3fd3a97 into pypa:main Nov 23, 2021
@ofek
Copy link
Sponsor Contributor Author

ofek commented Nov 23, 2021

Thanks!

@ofek ofek deleted the patch-1 branch November 23, 2021 21:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofek @pradyunsg @uranusjr