Fix various typing errors on Windows #10674
Conversation
uranusjr
added
the
skip news
| from wsgi import StartResponse, WSGIApplication, WSGIEnvironment | ||
| from _typeshed.wsgi import StartResponse, WSGIApplication, WSGIEnvironment |
There was a problem hiding this comment.
This is what Werkzeug does to satisfy Mypy.
|
Uh, now POSIX does not like |
uranusjr
force-pushed
the
mypy-fix-windows
branch
2 times, most recently
from
00d1040
to
edf8631
Compare
uranusjr
force-pushed
the
mypy-fix-windows
branch
from
edf8631
to
51f7aa9
Compare
|
Uh, this is all so terrible. I gave up on a couple of files and applied file-wide disables instead 馃槥 |
| @@ -6,7 +6,7 @@ | |||
| from typing import Any, Optional, cast | |||
| from unittest import mock | |||
|
|
|||
| import freezegun # type: ignore | |||
| import freezegun # type: ignore # mypy: no-warn-unused-ignores | |||
There was a problem hiding this comment.
Why do we need this type: ignore? What fails if we remove it?
There was a problem hiding this comment.
It was needed for me at some point but I just tried and this is not needed anymore. Not sure what changed, but I鈥檓 only interested in getting my pre-commit to work TBH so let鈥檚 revert this.
|
Should we set up CI to run linters on Windows as well? |
|
Not really worth it IMO, it鈥檚 slow and only helps in edge cases that are relatively easy to spot. |
|
Any further comments on this? |
|
Nope. Feel free to merge. :) |
馃し