Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from tox to Nox #10693

Merged
merged 11 commits into from Dec 3, 2021
Merged

Move from tox to Nox #10693

merged 11 commits into from Dec 3, 2021

Conversation

DiddiLeija
Copy link
Member

@DiddiLeija DiddiLeija commented Nov 29, 2021 •
edited

Closes #6721. Move all our CI from tox to Nox, and update documentation.

@pypa/pip-team @theacodes

@DiddiLeija
Add a coverage session to our noxfile
097709b 
That way, we can move from tox to Nox without problems. See pypa#6721 for details.
@DiddiLeija
Make some fixes to the coverage Nox session
7c3fd81 
- Simplify it, by replacing a run with a Python if statement.
- Pass an env argument to the coverage call to ensure it will work.
@DiddiLeija
Simple fixes to the coverage Nox session
5c91612
@DiddiLeija
Replace tox with Nox (CLI, docs)
7ced6c5
@DiddiLeija
Remove the tox config file
aee9361
@DiddiLeija DiddiLeija mentioned this pull request Nov 29, 2021
Closed
@DiddiLeija
Copy link
Member Author

Ok... after a (really) dirty commit history, I think this is ready. What do you think?

@theacodes
Copy link
Member

🎉

@DiddiLeija
Copy link
Member Author

Just give me a minute to fix this mess...

@DiddiLeija
Copy link
Member Author

Ok, I think that's all from my side.

@crwilcox
Copy link

Thanks for putting the work in here @DiddiLeija!

DiddiLeija
DiddiLeija commented Nov 30, 2021
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
pradyunsg
pradyunsg reviewed Dec 1, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good idea to add a session for vendoring, and change our CI to use it.

noxfile.py Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@DiddiLeija
Copy link
Member Author

@pradyunsg thanks for the suggestions, I'll be working on them today.

@DiddiLeija
Copy link
Member Author

It would be a good idea to add a session for vendoring, and change our CI to use it.

We already have a vendoring step!

pip/noxfile.py

Lines 172 to 173 in 9cf35b2

@nox.session
def vendoring(session: nox.Session) -> None:

We can just implement it in our CI, right?

@DiddiLeija
Copy link
Member Author

All done now. Any other commentaries?

pradyunsg
pradyunsg reviewed Dec 1, 2021
View reviewed changes
news/10693.trivial.rst Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@DiddiLeija
Copy link
Member Author

@pradyunsg I made your suggestions.

@DiddiLeija
Copy link
Member Author

@pradyunsg feel free to merge this pull request!

@pradyunsg pradyunsg merged commit 8ef91cf into pypa:main Dec 3, 2021
@pradyunsg
Copy link
Member

Thanks for the nudge! ^>^

@DiddiLeija DiddiLeija deleted the tox-to-nox branch December 3, 2021 14:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate if we can replace our tox+invoke setup with nox
4 participants
@DiddiLeija @theacodes @crwilcox @pradyunsg