Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress the progress bar with --quiet and --log #10930

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Mar 1, 2022

Closes #10915

@q0w q0w closed this Mar 2, 2022
@q0w q0w reopened this Mar 2, 2022
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Apr 8, 2022
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Apr 8, 2022
Comment on lines +305 to +292
if options.quiet:
options.progress_bar = "off"
Copy link
Member

@uranusjr uranusjr Apr 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that the combination makes a lot of sense, but what would/should pip install --quiet --progress-bar=on do? What if --log is added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the change is useless because you could just add --progress-bar=off to silence the output?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not useless since --quiet should disable the progress bar. I’m only wondering what happens if the user actually wants the progress bar back for some reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but I think your patch here as-is would not allow it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, im going to update the patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranusjr but by default progress_bar = on

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Perhaps we need to add and change the default to auto or something. Let’s do it in another PR though, in here we can make --quiet override --progress-bar=on.

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Apr 9, 2022
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants