Replace Iterator[T] with Generator[T,None, None] #11007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to fix the black-click thing first I guess. |
|
There’s another open PR for that, with extra changes added in (#11008). |
github-actions
bot
added
the
needs rebase or merge
github-actions
bot
added
the
needs rebase or merge
uranusjr
reviewed
Apr 8, 2022
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
Apr 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems, python/typeshed#7430 will be merged, so it would be more precise to use Generator for functions with
@contextmanagerdecorator. For other cases it could be reverted if you want.