Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add additional context to protected_pip.py about how it works" #11078

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Revert "Add additional context to protected_pip.py about how it works" #11078

merged 1 commit into from
Apr 30, 2022

Conversation

pradyunsg
Copy link
Member

This reverts commit 84ee57d, which was a part of #11076. Not sure why but CI has been failing since this was merged. :/

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 30, 2022
@pradyunsg
Copy link
Member Author

pradyunsg commented Apr 30, 2022 •
edited 

>>> "".split(":")
['']

Ok, so the os.environ.get change caused a behaviour change -- it gives out a non-empty list after the split call, resulting in PYTHONPATH having an extra os.pathsep at the end. Still not sure why Python has a fatal error due to this though.

@pradyunsg pradyunsg merged commit 64dd9e9 into pypa:main Apr 30, 2022
@pradyunsg pradyunsg deleted the revert-protected-pip-rewrite branch April 30, 2022 11:55
@pradyunsg
Copy link
Member Author

Merging eagerly, since this blocks making a release.

This was referenced Apr 30, 2022
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pradyunsg