Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't maintain 2 copies of change_root #11600

Merged
merged 1 commit into from Nov 16, 2022
Merged

Don't maintain 2 copies of change_root #11600

merged 1 commit into from Nov 16, 2022

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Nov 16, 2022

The change_root function was added twice:

In ae324d1 and in 36a9b36

@hroncok
Don't maintain 2 copies of change_root
f7589d6 
The change_root function was added twice:

In ae324d1
and in 36a9b36
@hroncok hroncok marked this pull request as draft November 16, 2022 12:30
@hroncok hroncok marked this pull request as ready for review November 16, 2022 12:58
@pradyunsg pradyunsg merged commit 45debcc into pypa:main Nov 16, 2022
@pradyunsg
Copy link
Member

Thanks @hroncok!

@hroncok hroncok deleted the no_two_change_roots branch November 16, 2022 19:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hroncok @pradyunsg @uranusjr