Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle keyring auth subprocess newlines on Windows #11759

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

pradyunsg
Copy link
Member

Closes #11658

The line endings on Windows are not required to be `\n`.
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 28, 2023
@pradyunsg
Copy link
Member Author

This is a subset of from #11029, which fixes the blocking issue for the 23.0 release.

@pradyunsg pradyunsg added this to the 23.0 milestone Jan 29, 2023
@pradyunsg pradyunsg merged commit efedf09 into pypa:main Jan 29, 2023
@pradyunsg pradyunsg deleted the fix-keyring-auth branch January 29, 2023 01:36
@pradyunsg
Copy link
Member Author

Holler if there's any concerns with this! :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyring support broken on Windows when keyring.exe is found on PATH after #11589
1 participant