Switch to ruff for linting #12073
Merged
Switch to ruff for linting #12073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this needs a NEWS entry, but if anyone wants me to add one, just say. I'll add a follow-up commit here to replace isort as well once the initial CI checks have completed. |
q0w
reviewed
Jun 5, 2023
pyproject.toml
Outdated
Comment on lines
78
to
79
| ".nox", | ||
| ".tox", |
There was a problem hiding this comment.
its by default excluded https://beta.ruff.rs/docs/settings/#exclude
it should be extend-exclude (?)
There was a problem hiding this comment.
Thanks. I got this by running flake8-to-ruff and didn't change much from what it suggested. I'll fix this.
q0w
reviewed
Jun 5, 2023
Co-authored-by: q0w <43147888+q0w@users.noreply.github.com>
pradyunsg
approved these changes
Jun 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12072