Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade distlib to 0.3.7 #12359

Closed
wants to merge 3 commits into from

Conversation

FlavioAmurrioCS
Copy link
Contributor

Updated src/pip/_vendor/vendor.txt to update distlib to 0.3.7 and then ran pipx run vendoring sync . -v

@sbidoul
Copy link
Member

sbidoul commented Oct 16, 2023

Thanks for submitting this @FlavioAmurrioCS. I assign it to 24.0 so we don't forget.

There is a failing test that seems to be related to the upgrade. If you have a chance to investigate that would be most welcome.

@sbidoul sbidoul added the project: vendored dependency Related to a vendored dependency label Oct 16, 2023
@FlavioAmurrioCS
Copy link
Contributor Author

@sbidoul I will take a look at this sometime tomorrow. Been busy with work :/

@pradyunsg
Copy link
Member

pradyunsg commented Oct 19, 2023

The failure is due to an xfail that no longer fails, because that's one functional behaviour that's improved in distlib!

[XPASS(strict)] colon not supported in wheel entry point name?

test_uninstall_entry_point_colon_in_name is the relevant test.

@FlavioAmurrioCS
Copy link
Contributor Author

pre-commit.ci autofix

@FlavioAmurrioCS
Copy link
Contributor Author

I went ahead and updated test_uninstall_entry_point_colon_in_name. Thanks for the info @pradyunsg !

@Secrus
Copy link
Member

Secrus commented Jan 25, 2024

By now, distlib already has 0.3.8 version, you might want to use it.

@sbidoul
Copy link
Member

sbidoul commented Jan 27, 2024

@FlavioAmurrioCS thanks for filing this. I've cherry-picked your commits in #12493, so closing this one.

@sbidoul sbidoul closed this Jan 27, 2024
@FlavioAmurrioCS FlavioAmurrioCS deleted the upgrade-distlib branch January 27, 2024 13:46
@FlavioAmurrioCS
Copy link
Contributor Author

Thanks @sbidoul

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants