Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests broken by Setuptools 69.0.3 which now preserves underscores in egg_info #12458

Closed
wants to merge 1 commit into from

Conversation

ichard26
Copy link
Member

@ichard26 ichard26 commented Jan 1, 2024

Let's see if this works...

Some tests are still broken due to pypa/setuptools#4167.

@@ -119,7 +119,7 @@ def test_check_complicated_name_missing(script: PipTestEnvironment) -> None:

# Without dependency
result = script.pip("install", "--no-index", package_a_path, "--no-deps")
assert "Successfully installed package-A-1.0" in result.stdout, str(result)
assert "Successfully installed package_A-1.0" in result.stdout, str(result)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should do a regex match so the pip test suite is not dependent on setuptools>=69 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or a simple or

Copy link
Member Author

@ichard26 ichard26 Jan 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I totally forgot about that. I'm glad you picked this up. Thanks! 🙂

@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 14, 2024
@sbidoul
Copy link
Member

sbidoul commented Jan 14, 2024

I think I found a reasonable way to fix the rest of the failures. If you don't mind I'll cherry-pick your commit here and continue.

@ichard26
Copy link
Member Author

See linked PR which supersedes this one.

@ichard26 ichard26 closed this Jan 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants