Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert more record classes to dataclasses #12659

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Convert more record classes to dataclasses #12659

wants to merge 3 commits into from

Commits on May 5, 2024

  1. Convert more record classes to dataclasses 

    - Removes BestCandidateResult's iter_all() and iter_applicable()
  methods as they were redundant

- Looking closer at SelectionPreferences, it only used slots to prevent
  accidental new attribute assignment (not for reduced memory usage as I
  previously thought) so this is safe to convert

- Removes ParsedLine's is_requirement attribute as it was awkward to use
  (to please mypy, you would need to add asserts on .requirement)
    @ichard26
    ichard26 committed May 5, 2024
    Configuration menu
    Copy the full SHA
    c4f08e0 View commit details
    Browse the repository at this point in the history

  2. Revert SelectionPreferences as it's performance-sensitive

    @ichard26
    ichard26 committed May 5, 2024
    Configuration menu
    Copy the full SHA
    40a9a20 View commit details
    Browse the repository at this point in the history

  3. Convert FrozenRequirement

    @ichard26
    ichard26 committed May 5, 2024
    Configuration menu
    Copy the full SHA
    d05323c View commit details
    Browse the repository at this point in the history