New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't crash when crawling invalid wheels; if installing directly, fail if invalid or unsupported #1315

Merged
merged 1 commit into from Nov 16, 2013

Conversation

Projects
None yet
1 participant
@qwcode
Contributor

qwcode commented Nov 15, 2013

  • when walking links, skip invalid wheel filenames, don't crash
  • if installing directly from a wheel, fail if it has an invalid name or is unsupported

redo of #1305, with the main difference being that pip.index.Link is now back to being ignorant of what kind of archives it's linking too, i.e. no link.wheel or link.invalid_wheel_filename properties.

- if installing directly from a wheel, fail if it has an invalid name…
… or is unsupported

- when walking links, skip invalid wheel filenames, don't crash

qwcode added a commit that referenced this pull request Nov 16, 2013

Merge pull request #1315 from qwcode/check_wheel_support
don't crash when crawling invalid wheels;  if installing directly, fail if invalid or unsupported

@qwcode qwcode merged commit a92b190 into pypa:develop Nov 16, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment