Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1439 Fix Proposal #1467

Closed
wants to merge 1 commit into from
Closed

Conversation

z4r
Copy link

@z4r z4r commented Jan 13, 2014

This pull request is a proposal to enhance #1439: It makes --no-use-wheel mandatory with --install_option.

@mindflayer
Copy link

Safest and easiest approach imho. +1

@dstufft dstufft closed this May 18, 2016
@dstufft
Copy link
Member

dstufft commented May 18, 2016

Accidentally closed this, reopening. Sorry!

@dstufft dstufft reopened this May 18, 2016
@BrownTruck
Copy link
Contributor

Hello!

As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the master branch. However, this Pull Request was made against the develop branch so it will need to be resubmitted against master. Unfortunately, this pull request does not cleanly merge against the current master branch.

If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged.

If this pull request is still valid, please rebase it against master (or merge master into it) and resubmit it against the master branch, closing and referencing the original Pull Request.

If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:

This pull request is a proposal to enhance #1439: It makes --no-use-wheel mandatory with --install_option.

---

*This was migrated from pypa/pip#1467 to reparent it to the ``master`` branch. Please see original pull request for any previous discussion.*

@mindflayer
Copy link

mindflayer commented May 19, 2016

Hi @BrownTruck,
it looks like many things changed since our (@z4r and me) proposal, and it seems already fixed by the behaviour at:
https://github.com/pypa/pip/blob/master/pip/cmdoptions.py#L54

@dstufft
Copy link
Member

dstufft commented May 19, 2016

Ok Great. Thanks!

@dstufft dstufft closed this May 19, 2016
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants