Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index exceptions #3274

Merged
merged 2 commits into from Nov 30, 2015
Merged

Index exceptions #3274

merged 2 commits into from Nov 30, 2015

Conversation

xavfernandez
Copy link
Member

  • Make sure SSLError is catched before ConnectionError
  • Remove useless level arg

Review on Reviewable

@xavfernandez
Fix exception catch order
b018c9a 
SSLError inherits from ConnectionError
@xavfernandez
Drop the level argument
d48bc5c 
it is useless since 52ca026
@xavfernandez xavfernandez reopened this Nov 30, 2015
xavfernandez added a commit that referenced this pull request Nov 30, 2015
@xavfernandez
Merge pull request #3274 from xavfernandez/index_exceptions
1fd381e 
Cleanup HTMLPage.get_page exception handling
@xavfernandez xavfernandez merged commit 1fd381e into pypa:develop Nov 30, 2015
@xavfernandez xavfernandez deleted the index_exceptions branch November 30, 2015 21:30
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xavfernandez