Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent the completion text and use textwrap.dedent #4509

Merged
merged 3 commits into from
May 30, 2017

Conversation

pradyunsg
Copy link
Member

This is a trivial change.

@dstufft
Copy link
Member

dstufft commented May 23, 2017

You've got linter failures here.

Use str.format to format in the long line.
@pradyunsg
Copy link
Member Author

Here's a hacky-ish way to work around that.

@pradyunsg
Copy link
Member Author

@dstufft Thoughts?

COMPREPLY=( $( COMP_WORDS="${COMP_WORDS[*]}" \\
COMP_CWORD=$COMP_CWORD \\
PIP_AUTO_COMPLETE=1 $1 ) )
_pip_completion()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about putting each script into a resource file and using pkg_resources to get them

@dstufft dstufft merged commit 2dd2375 into pypa:master May 30, 2017
@pradyunsg pradyunsg deleted the misc/indent-completion-snippets branch June 13, 2017 19:28
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants