Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issue #4675: fix Git.check_version() #4676

Merged
merged 8 commits into from
Oct 5, 2017
Merged

Address issue #4675: fix Git.check_version() #4676

merged 8 commits into from
Oct 5, 2017

Commits on Oct 5, 2017

  1. Add a failing test case to test_git_check_version().

    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    4c97794 View commit details
    Browse the repository at this point in the history

  2. Fix test expectations (the tests now fail).

    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    3e7ce53 View commit details
    Browse the repository at this point in the history

  3. Fix check_version() (the tests now pass).

    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    3e4f808 View commit details
    Browse the repository at this point in the history

  4. Change check_version() to accept a commit hash / id.

    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    d1b9441 View commit details
    Browse the repository at this point in the history

  5. Choose a better name, and other clean-ups.

    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    d646aac View commit details
    Browse the repository at this point in the history

  6. Add news entry.

    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    b0d1160 View commit details
    Browse the repository at this point in the history

  7. Address @pradyunsg's review comment.

    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    da30b70 View commit details
    Browse the repository at this point in the history

  8. Add a note to the pip-install docs. 

    This was suggested by @xavfernandez in the review comments.
    @cjerdonek
    cjerdonek committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    cf23b06 View commit details
    Browse the repository at this point in the history