Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pep518 binaries #4800

Closed
wants to merge 8 commits into from
Closed

Pep518 binaries #4800

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2017

This feature is unused and could result in undesired
effects (eg. rebuilding numpy while installing build
dependencies). We drop the feature here.

Edit: I should also mention that recursive behavior (the existing implementation) is extremely bug-prone and can timeout in some cases without warning.

This feature is unused and could result in undesired
effects (eg. rebuilding numpy while installing build
dependencies). We drop the feature here.
@ghost
Copy link
Author

ghost commented Oct 20, 2017

The documentation for --only-binary :all: says the following:

Do not use source packages. Can be supplied multiple times, and each time adds to the existing value. Accepts either :all: to disable all source packages, :none: to empty the set, or one or more package names with commas between them. Packages without binary distributions will fail to install when this option is used on them.

However, there is no wheel available for the simple package. That would seem to suggest that the documentation is not correct if pip is passed links.

@pfmoore Should I open a bug report about that?

@ghost
Copy link
Author

ghost commented Oct 20, 2017

There's the test failure we're looking for.

@ghost
Copy link
Author

ghost commented Oct 20, 2017

For reference the modification of the binary should be changing this:

[build-system]
requires=["simple==3.0", "setuptools", "wheel"]

To this:

[build-system]
requires=["simplewheel==2.0", "setuptools", "wheel"]

@pfmoore
Copy link
Member

pfmoore commented Oct 20, 2017

"This feature is unused". You don't say what feature, other than the vague title "Pep518 binaries".

But don't worry. You've seen my most recent comment on #4799, so let's wait till we get agreement on whether PEP 518 should change, or whether the recursive behaviour is required.

@ghost
Copy link
Author

ghost commented Oct 20, 2017

Yes, will discuss there.

@ghost
Copy link
Author

ghost commented Oct 20, 2017

Sorry, please discuss in #4799.

@ghost ghost closed this Oct 20, 2017
@ghost ghost deleted the pep518-binaries branch October 20, 2017 22:41
@ghost ghost mentioned this pull request Jan 24, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants