Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide global options for subcommands unless --verbose #5746

Closed
wants to merge 6 commits into from

Conversation

techtonik
Copy link
Contributor

@techtonik techtonik commented Sep 1, 2018

Rebased #4433, which got bitrotten again.

I just rebased it. Need more time to see how can I run pip from checkout to test that nothing is broken during rebase. https://pip.pypa.io/en/stable/development/ is pretty silent about that.

@techtonik
Copy link
Contributor Author

Filled an issue about easy "development environment setup" #5747

@techtonik
Copy link
Contributor Author

techtonik commented Sep 3, 2018

Figured out how to run pip from development source. Tests:

  • pip, pip -h and pip help should show commands and general options
  • pip help -h and pip help help should show subcommand help, its options, but no general options. Instead there should be a text message to specify -v to show those.
  • show subcommand, its options and general options
    • pip help -h -v
    • pip help help -v

@techtonik
Copy link
Contributor Author

Okay, this is broken right now.

$ python src/pip help help -v

Usage:   
  pip help <command>

Description:
  Show help for commands


Add '-v' flag to show general options.
There was an error checking the latest version of pip
Traceback (most recent call last):
  File "/home/techtonik/p/pip/src/pip/_internal/utils/outdated.py", line 106, in pip_version_check
    find_links=options.find_links,
AttributeError: Values instance has no attribute 'find_links'

@techtonik
Copy link
Contributor Author

Looks like the problem is with current master. Removing /home/techtonik/.cache/pip/selfcheck.json fires up the bug in virtualenv as well.

@techtonik
Copy link
Contributor Author

techtonik commented Sep 3, 2018

Ok. That's a duplicate of #5433. There is no problem with this PR - it is ready to be merged.

@techtonik
Copy link
Contributor Author

This can be merged now.

@pradyunsg
Copy link
Member

Thanks for rebasing this @techtonik!

There's #5399 for having a discussion on this specific topic so if there's consensus that this is the approach we want to take, we'll proceed. :)

@pradyunsg pradyunsg added the state: needs discussion This needs some more discussion label Sep 24, 2018
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Jan 13, 2019
@pradyunsg
Copy link
Member

Thanks for filing this @techtonik!

This is still up for discussion but I'm gonna close this PR since it's bitrotten. We can continue the discussion on this on the issue and come back to this once we have a decision.

@pradyunsg pradyunsg closed this May 23, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master state: needs discussion This needs some more discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants