Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest: Use get_closest_marker #6368

Merged
merged 1 commit into from Apr 4, 2019
Merged

Pytest: Use get_closest_marker #6368

merged 1 commit into from Apr 4, 2019

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Mar 29, 2019

See pytest-dev/pytest#4564

I consider this a trivial change.

@cjerdonek cjerdonek added C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) labels Mar 30, 2019
@xavfernandez
Copy link
Member

@hroncok Thanks for the PR, could you rebase it on master ?

@hroncok
Copy link
Contributor Author

hroncok commented Apr 3, 2019

Done.

@cjerdonek
Copy link
Member

cjerdonek commented Apr 4, 2019

@hroncok Sorry, you'll need to do it one more time. pip's CI was broken because of an unpinned dependency, so your PR's checks are showing as not passing.

(Actually, I don't think this PR will work until we're using pytest 4.1.0+.) (I see now that the new function has existed in pytest since v3.6.0.)

@hroncok
Copy link
Contributor Author

hroncok commented Apr 4, 2019

Done.

@xavfernandez xavfernandez merged commit d4264dc into pypa:master Apr 4, 2019
@xavfernandez
Copy link
Member

@hroncok thanks :)

@hroncok hroncok deleted the pytest4 branch April 4, 2019 11:08
@lock
Copy link

lock bot commented May 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants