Support non-ascii cwds in make_subprocess_output_error() #6683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to PR #6671 to fix another potential Python 2
str
issue in PR #6655.Currently,
make_subprocess_output_error()
will raise aUnicodeDecodeError
like the following when callingstr.format()
if thecwd
contains a non-ascii character:This PR fixes that issue by safely converting the
cwd
to text (unicode
in Python 2) before callingstr.format()
. It does this by introducing apath_to_display()
function that is similar to thestr_to_display()
function introduced in PR #6671, except tailored to paths rather than to general bytes objects.