Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental support for installing wheel archives #694

Merged
merged 3 commits into from Oct 4, 2012

Conversation

qwcode
Copy link
Contributor

@qwcode qwcode commented Oct 2, 2012

This is just the install support w/o wheel building/caching.
The "pip build/bdist_wheel" effort will take more time since it involves some refactor and maybe some debate.

@qwcode
Copy link
Contributor Author

qwcode commented Oct 2, 2012

@dholth @pfmoore, @pnasrat @rubik : ok, here's just the install support. let me know if I mis-carved anything.

@pfmoore : notice/confirm the fix I made related to your new "binary" function for py3. you can see the previous failure here: https://travis-ci.org/#!/pypa/pip/jobs/2633020

also, @dholth, can you confirm my understanding of this in simple.dist metadata:

Requires-Dist: beaglevote; extra == 'voting'

I'm guessing that's there to test the extra syntax that only markerlib understands now? You can't install simple.dist w/o markerlib, because it complains about the non-existing beaglevote. So, if that's true, for now, I'm saying pip requires markerlib in the usage? or maybe only for extra syntax?

@dholth
Copy link
Member

dholth commented Oct 2, 2012

The next version of distribute will include markerlib. Until then, all markers evaluate to true (oops) And pip will try to install all the extras. Distribute 0.6.28 is required.

For py 2.5 markerlib doesn't work (no compile(ast)) so we just make non-empty markers false, empty ones or no markers are true. They work correctly in 2.6 and up.

On Oct 2, 2012, at 2:42 AM, Marcus Smith notifications@github.com wrote:

@dholth @pfmoore, @pnasrat @rubik : ok, here's just the install support. let me know if I mis-carved anything.

@pfmoore : notice/confirm the fix I made related to your new "binary" function for py3

also, @dholth, can you confirm my understanding of this in simple.dist metadata:

Requires-Dist: beaglevote; extra == 'voting'
I'm guessing that's there to test the extra syntax that only markerlib understands now? You can't install simple.dist w/o markerlib, because it complains about the non-existing beaglevote. So, if that's true, for now, I'm saying pip requires markerlib in the usage? or maybe only for extra syntax?


Reply to this email directly or view it on GitHub.

@dholth
Copy link
Member

dholth commented Oct 2, 2012

Use exename instead of binary()

On Oct 2, 2012, at 2:42 AM, Marcus Smith notifications@github.com wrote:

@dholth @pfmoore, @pnasrat @rubik : ok, here's just the install support. let me know if I mis-carved anything.

@pfmoore : notice/confirm the fix I made related to your new "binary" function for py3

also, @dholth, can you confirm my understanding of this in simple.dist metadata:

Requires-Dist: beaglevote; extra == 'voting'
I'm guessing that's there to test the extra syntax that only markerlib understands now? You can't install simple.dist w/o markerlib, because it complains about the non-existing beaglevote. So, if that's true, for now, I'm saying pip requires markerlib in the usage? or maybe only for extra syntax?


Reply to this email directly or view it on GitHub.

@qwcode
Copy link
Contributor Author

qwcode commented Oct 2, 2012

The next version of distribute will include markerlib.
Until then, all markers evaluate to true (oops) And pip will try to install all the extras. Distribute 0.6.28 is required.

@dholth , to be clear...

  1. the beaglevote extra requirement in simple.dist is intentional and should be left in? yes?
  2. so for the short term though, we should say markerlib is required... certain version?

@qwcode
Copy link
Contributor Author

qwcode commented Oct 2, 2012

@dholth , @pfmoore. using exename now in latest commit. travis running...

@dholth
Copy link
Member

dholth commented Oct 2, 2012

Yes, and the newest markerlib

Marcus Smith notifications@github.com wrote:

The next version of distribute will include markerlib.
Until then, all markers evaluate to true (oops) And pip will try to install all the extras. Distribute 0.6.28 is required.

@dholth , to be clear...

  1. the beaglevote extra requirement in simple.dist is intentional and should be left in? yes?
  2. so for the short term though, we should say markerlib is required... certain version?

Reply to this email directly or view it on GitHub:
#694 (comment)

@qwcode
Copy link
Contributor Author

qwcode commented Oct 2, 2012

@dholth @pnasrat @pfmoore @rubik @brosner @jezdez

I'm ready to merge... anyone have concerns?

here's my list of reasons for why this is ok and good:

  1. wheels are only found if the user specifically uses the --use-wheel flag (or ofcourse if they install a wheel directly)
  2. the code is isolated enough for easy removal later, if the "experiment" fails
  3. pip users need binary install support
  4. wheel has momentum.
  5. there's multiple people contributing to this effort and reviewing.
  6. this isn't final; we'll keep improving this (namely in adding tag support and wheel building)
  7. we'll get more feedback and have better coordination this way vs it being a long running feature branch in dholth's fork.

@qwcode
Copy link
Contributor Author

qwcode commented Oct 3, 2012

@dholth @rubik @pfmoore :
I posted my thoughts for the new subcommand to handle wheel building. comments appreciated.
https://gist.github.com/3828683
If any of you think you might work on this, let me know. otherwise, I'd probably end up doing it in a week or so.
the idea being to reuse some of the work by @rubik, but just in subcommand form

@qwcode
Copy link
Contributor Author

qwcode commented Oct 3, 2012

@dholth @rubik @pfmoore :
also, since the more general topic of "caching" came up, I'm also thinking thru a new "--package-cache" option to "pip install"
https://gist.github.com/3828762
comments appreciated on that too.

@qwcode qwcode merged this pull request into pypa:develop Oct 4, 2012
@brosner
Copy link
Contributor

brosner commented Oct 5, 2012

I don't see the commit 941390f in the develop branch of pip. Did something happen?

@qwcode
Copy link
Contributor Author

qwcode commented Oct 5, 2012

Jannis and I talked on IRC. he thought it was premature. not enough input. I reverted and will reopen this pull and post something on the mailing list to get more input and conversation going.

@rubik
Copy link

rubik commented Oct 5, 2012

What? But if this does not get merged how can more people try it?

@jezdez
Copy link
Member

jezdez commented Oct 5, 2012

@rubik check out #699 and install @qwcode's wheel_install branch. E.g. run in a venv: pip install https://github.com/qwcode/pip/zipball/wheel_install and try it yourself.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants