New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental support for installing wheel archives #694
Conversation
@dholth @pfmoore, @pnasrat @rubik : ok, here's just the install support. let me know if I mis-carved anything. @pfmoore : notice/confirm the fix I made related to your new "binary" function for py3. you can see the previous failure here: https://travis-ci.org/#!/pypa/pip/jobs/2633020 also, @dholth, can you confirm my understanding of this in simple.dist metadata:
I'm guessing that's there to test the extra syntax that only markerlib understands now? You can't install simple.dist w/o markerlib, because it complains about the non-existing beaglevote. So, if that's true, for now, I'm saying pip requires markerlib in the usage? or maybe only for extra syntax? |
The next version of distribute will include markerlib. Until then, all markers evaluate to true (oops) And pip will try to install all the extras. Distribute 0.6.28 is required. For py 2.5 markerlib doesn't work (no compile(ast)) so we just make non-empty markers false, empty ones or no markers are true. They work correctly in 2.6 and up. On Oct 2, 2012, at 2:42 AM, Marcus Smith notifications@github.com wrote:
|
Use exename instead of binary() On Oct 2, 2012, at 2:42 AM, Marcus Smith notifications@github.com wrote:
|
@dholth , to be clear...
|
Yes, and the newest markerlib Marcus Smith notifications@github.com wrote:
|
@dholth @pnasrat @pfmoore @rubik @brosner @jezdez I'm ready to merge... anyone have concerns? here's my list of reasons for why this is ok and good:
|
@dholth @rubik @pfmoore : |
@dholth @rubik @pfmoore : |
I don't see the commit 941390f in the develop branch of pip. Did something happen? |
Jannis and I talked on IRC. he thought it was premature. not enough input. I reverted and will reopen this pull and post something on the mailing list to get more input and conversation going. |
What? But if this does not get merged how can more people try it? |
This is just the install support w/o wheel building/caching.
The "pip build/bdist_wheel" effort will take more time since it involves some refactor and maybe some debate.