Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "require_virtualenv" in `pip config` #6991

Merged
merged 2 commits into from Sep 19, 2019

Conversation

@pradyunsg
Copy link
Member

pradyunsg commented Sep 7, 2019

We'd want it to work even after someone (eg. me) does pip config set global.require-virtualenv true. :)

@chrahunt

This comment has been minimized.

Copy link
Member

chrahunt commented Sep 7, 2019

Is it worth a test? We'll be thankful for it when transitioning the CLI (#4659), but that is probably some ways off.

@pradyunsg pradyunsg merged commit 8d6e320 into pypa:master Sep 19, 2019
22 checks passed
22 checks passed
Linux Build #20190907.12 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20190907.12 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x86) Test Primary Python27-x86 succeeded
Details
Windows (Test Primary Python37-x64) Test Primary Python37-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20190907.12 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@pradyunsg pradyunsg deleted the pradyunsg:config/ignore-require-virtualenv branch Sep 19, 2019
@pradyunsg

This comment has been minimized.

Copy link
Member Author

pradyunsg commented Sep 19, 2019

Is it worth a test?

Probably, however we don't have any existing tests for this area (--require-virtualenv and commands that ignore it). It might make sense to add a "help wanted" Internal Cleansing issue, about this.

@lock lock bot added the S: auto-locked label Oct 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.