Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "require_virtualenv" in pip config #6991

Merged
merged 2 commits into from Sep 19, 2019

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Sep 7, 2019

We'd want it to work even after someone (eg. me) does pip config set global.require-virtualenv true. :)

@pradyunsg pradyunsg added type: enhancement C: configuration type: bugfix and removed type: enhancement labels Sep 7, 2019
@chrahunt
Copy link
Member

@chrahunt chrahunt commented Sep 7, 2019

Is it worth a test? We'll be thankful for it when transitioning the CLI (#4659), but that is probably some ways off.

@pradyunsg pradyunsg merged commit 8d6e320 into pypa:master Sep 19, 2019
22 checks passed
@pradyunsg pradyunsg deleted the config/ignore-require-virtualenv branch Sep 19, 2019
@pradyunsg
Copy link
Member Author

@pradyunsg pradyunsg commented Sep 19, 2019

Is it worth a test?

Probably, however we don't have any existing tests for this area (--require-virtualenv and commands that ignore it). It might make sense to add a "help wanted" Internal Cleansing issue, about this.

@lock lock bot added the auto-locked label Oct 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked C: configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants