Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix Tests): Change method from shutil.remove to shutil.rmtree #7191

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@qiell
Copy link
Contributor

qiell commented Oct 14, 2019

  • remove was not a member of shutil and tests were failing because of
    it. To fix it, shutil.rmtree is used.

Signed-off-by: Akash Srivastava akashsrivastava4927@gmail.com

fixes: #7190

qiell added 2 commits Oct 14, 2019
- remove was not a member of shutil and tests were failing because of
it. To fix it, shutil.rmtree is used.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
@qiell qiell force-pushed the qiell:fix/update-shutil-remove-to-rmtree branch from b89e35f to a6e098a Oct 14, 2019
@pradyunsg

This comment has been minimized.

Copy link
Member

pradyunsg commented Oct 15, 2019

Hah! I'm stupid. :)

@pradyunsg pradyunsg merged commit ba63e01 into pypa:master Oct 15, 2019
24 checks passed
24 checks passed
🤖 (ubuntu-18.04, docs)
Details
🤖 (ubuntu-18.04, lint)
Details
Linux Build #20191014.5 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20191014.5 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x86) Test Primary Python27-x86 succeeded
Details
Windows (Test Primary Python37-x64) Test Primary Python37-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20191014.5 succeeded
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@qiell qiell deleted the qiell:fix/update-shutil-remove-to-rmtree branch Nov 5, 2019
@lock lock bot added the S: auto-locked label Dec 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.