Move download copying out of unpacking functions #7510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One less use of `download_dir` in `unpack_file_url`, which will make it easier to factor out.
chrahunt
added
type: refactor
sbidoul
reviewed
Dec 26, 2019
Now our "unpacking" functions aren't also for sometimes populating the download directory.
chrahunt
force-pushed
the
refactor/operations-prepare-move-download-up
branch
from
5f725b6
to
ce9ddbb
Compare
|
Yes, thank you. I have updated it and |
sbidoul
approved these changes
Dec 26, 2019
|
Ping @pypa/pip-committers, any additional feedback? |
pradyunsg
approved these changes
Dec 29, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #7049.