Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs: comment stripping comes _after_ line continuation processing #7780

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

AndydeCleyre
Copy link
Contributor

Fixes #7728

Copy link
Contributor

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pradyunsg
Copy link
Member

Honestly, this feels like a fairly minor correction overall, and I can't come to justify making someone spend the 5 minutes needed to add a .doc NEWS fragement to this.

So... following my own doc-PRs are fine during the beta comment, merging this! :)

@pradyunsg pradyunsg merged commit 45f762e into pypa:master Apr 27, 2020
@pradyunsg
Copy link
Member

Hurray! Thanks @AndydeCleyre for the PR! And, thanks for taking the time to review this @atugushev and @sbidoul! ^>^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect documentation on requirements.txt format
4 participants