Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resolver: implement --user #7997

Merged
merged 2 commits into from May 15, 2020
Merged

New resolver: implement --user #7997

merged 2 commits into from May 15, 2020

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Apr 8, 2020 •
edited

The first three commits are from #7990.

I think the use_user_site implementation is best covered by existing tests. Let’s see what Travis thinks… if this works we should have less failing tests than in #7990.

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 8, 2020
@uranusjr
Copy link
Member Author

uranusjr commented Apr 8, 2020

Ah, the --user tests are skipped on Travis since their are not compatible with venv. I guess I’ll copy some tests then.

@pradyunsg
Copy link
Member

@uranusjr I think we can drop the --use-venv from Travis CI.

@pradyunsg pradyunsg mentioned this pull request Apr 8, 2020
Closed
@uranusjr
Copy link
Member Author

uranusjr commented Apr 8, 2020

I found that a lot of the tests are of poor quality anyway (most are network tests), and ended up porting them to test_new_resolver_user.py. We can use them to replace tests in test_install_user.py in the future.

@pradyunsg
Copy link
Member

Oooooooo.

We'd need to think about how to represent "user installs" in the YAML tests.

/cc @ilanschnell

@uranusjr uranusjr marked this pull request as ready for review April 9, 2020 11:59
@uranusjr uranusjr marked this pull request as draft April 10, 2020 13:23
@uranusjr uranusjr marked this pull request as ready for review April 10, 2020 14:03
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Apr 14, 2020
@pradyunsg pradyunsg added this to In progress in New Resolver Implementation Apr 27, 2020
@uranusjr
Implement use-user-site
d806279
@uranusjr
Add tests for --user installs
6ab42a8 
Tests are based on equivalents from test_install_user.py with
modifications to appropriately monkey-patch things in the new resolver
module.
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label May 5, 2020
@pfmoore pfmoore merged commit e28b388 into pypa:master May 15, 2020
New Resolver Implementation automation moved this from In progress to Done May 15, 2020
@uranusjr uranusjr deleted the resolver-use-user-site branch May 17, 2020 10:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
No open projects
New Resolver Implementation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@uranusjr @pradyunsg @BrownTruck @pfmoore @pypa-bot