Enable --no-input option by adding docs and tests #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I get this PR reviewed? |
deveshks
force-pushed
the
no-input-tests
branch
3 times, most recently
from
b58f01c
to
a03c025
Compare
pradyunsg
reviewed
May 16, 2020
Comment on lines
248
to
249
| print(result) | ||
| assert 'User for {}:{}'.format(server.host, server.port) in result.stdout |
There was a problem hiding this comment.
Suggested change
| print(result) | |
| assert 'User for {}:{}'.format(server.host, server.port) in result.stdout | |
| assert 'User for {}:{}'.format(server.host, server.port) in result.stdout, str(result) |
There was a problem hiding this comment.
Fixed in latest commit
Thanks, I have addressed the review comments. Could I also get the PR approved/merged as well? |
|
Hi @pradyunsg , If there are no changes needed in this PR, I think this is ready to be approved/merged. |
|
May I get this PR merged? |
xavfernandez
approved these changes
Jun 26, 2020
|
Thanks for the approval @xavfernandez . May I please get this merged as well? |
|
Thanks @deveshks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and closes #7688 , towards #2429
Added tests to verify the behaviour of authentication prompts, with and without the
--no-inputflag, and added help text to enable the option in docs and in--help