Set max_rounds to an incredibly large number #8275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
skip news
|
This fails on Python 2.7. :( I second @pfmoore's suggestion of |
|
Ah because |
We really don't want to raise ResolutionTooDeep yet since the metric is not very useful. Try to avoid this until we come up with a better method to count.
uranusjr
force-pushed
the
very-large-round-count
branch
from
c728c1e
to
418d905
Compare
pradyunsg
approved these changes
May 20, 2020
pfmoore
approved these changes
May 20, 2020
This was referenced May 20, 2020
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really don’t want to raise ResolutionTooDeep yet since the metric is not very useful. Try to avoid this until we come up with a better method to count.