Add method to pip test result for path lookups #8295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder what's the purpose of having assertion after the return statement, since it seems that assertions don't have any special behavior in control flow, so that won't be executed. |
deveshks
reviewed
May 22, 2020
| @@ -353,6 +353,26 @@ def assert_installed(self, pkg_name, editable=True, with_files=[], | |||
| .format(**locals()) | |||
| ) | |||
|
|
|||
| def did_create(self, path, message=None): | |||
| return '{}\n{}'.format(message, self) if message else self | |||
There was a problem hiding this comment.
This line is being repeated across all functions, so it's better to pull this out in its own function, and then call the function here. Something like
message = get_message(....)
assert str(path) in self.files_created, message
|
The work has been done in #8303 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #6050