Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license requirement to _vendor/README.rst #8332

Merged
merged 2 commits into from Jun 29, 2020

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented May 27, 2020

Originally posted in GH-8330:

As pip is licensed under MIT, I believe packages shipped along (i.e. vendored) with pip must be released under MIT-compatible licenses, i.e. permissive licenses. [...] I am not a lawyer so there's a high chance that I am wrong though [...] I think our vendoring policy might want to require libraries to be vendored must be available under a MIT-compatible license. If this is agreed upon, I'll file a PR to clarify it.

I also added a lint commit to this PR, but if it's not agreed upon, I can easily drop it. Edit: the linting is moved to GH-8456. Furthermore, I'm not sure if this should be a trivial or documentation change.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 31, 2020
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label May 31, 2020
@McSinyx
Copy link
Contributor Author

McSinyx commented Jun 9, 2020

Gentle ping!

@McSinyx McSinyx force-pushed the vendor-license-compat branch 2 times, most recently from 21eacce to a877a42 Compare June 17, 2020 15:13
@McSinyx McSinyx changed the title Add license requirement to and lint vendor README.rst Add license requirement to README.rst Jun 17, 2020
@McSinyx
Copy link
Contributor Author

McSinyx commented Jun 18, 2020

I was thinking about this earlier today and apparently

Libraries to be vendored MUST be available under MIT-compatible licenses.

is a bit too strict, e.g. in pip's case it is OK (I think) to vendor LGPL libraries but not GPL ones.

Edit: I rephrased it, I wonder if I need to elaborate it with examples like above though.

@pradyunsg pradyunsg changed the title Add license requirement to README.rst Add license requirement to _vendor/README.rst Jun 25, 2020
@McSinyx
Copy link
Contributor Author

McSinyx commented Jun 29, 2020

@pradyunsg, may I have an additional review and possibly a merge?

Co-authored-by: Xavier Fernandez <xav.fernandez@gmail.com>
@pradyunsg pradyunsg added project: vendored dependency Related to a vendored dependency type: maintenance Related to Development and Maintenance Processes labels Jun 29, 2020
@pradyunsg
Copy link
Member

This is ready to merge, once the CI passes. :)

@pradyunsg pradyunsg merged commit 9e70876 into pypa:master Jun 29, 2020
@pradyunsg
Copy link
Member

Thanks @McSinyx! ^>^

@McSinyx McSinyx deleted the vendor-license-compat branch June 30, 2020 06:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
project: vendored dependency Related to a vendored dependency type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants