New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license requirement to _vendor/README.rst #8332
Conversation
8be984a
to
7a9ad4e
Compare
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
7a9ad4e
to
4db3d9c
Compare
Gentle ping! |
21eacce
to
a877a42
Compare
I was thinking about this earlier today and apparently
is a bit too strict, e.g. in pip's case it is OK (I think) to vendor LGPL libraries but not GPL ones. Edit: I rephrased it, I wonder if I need to elaborate it with examples like above though. |
a877a42
to
e38b83a
Compare
e38b83a
to
e2accf5
Compare
e2accf5
to
cef064d
Compare
@pradyunsg, may I have an additional review and possibly a merge? |
Co-authored-by: Xavier Fernandez <xav.fernandez@gmail.com>
This is ready to merge, once the CI passes. :) |
Thanks @McSinyx! ^>^ |
Originally posted in GH-8330:
I also added a lint commit to this PR, but if it's not agreed upon, I can easily drop it.Edit: the linting is moved to GH-8456. Furthermore, I'm not sure if this should be a trivial or documentation change.