Fix a merge issue that didn't get caught by Brown Truck #8464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
added
the
skip news
|
Hah. I am definitely wondering if we need to start using bors. |
|
/me goes and looks up bors. Quite possibly :-) Actually, it also made me think that we don't really test the code behind this new message. Mostly because I don't want to be adding tests that depend on the precise wording of error messages, but I have no idea how to test the code behind the message without doing just that. One for another day, I think... |
pradyunsg
approved these changes
Jun 18, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem with #8394 caused by another PR that got merged first. Didn't cause a merge conflict, so it didn't get picked up by Brown Truck.