Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve install conflict warning #8594

Merged
merged 14 commits into from Jul 28, 2020
Merged

Improve install conflict warning #8594

merged 14 commits into from Jul 28, 2020

Commits on Jul 27, 2020

  1. Refactor the logging calls into a dedicated loop

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    d77b5c2 View commit details
    Browse the repository at this point in the history

  2. Short circuit when there's nothing to report

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    42c62a0 View commit details
    Browse the repository at this point in the history

  3. Add messaging variation based on "new resolver" usage

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    efdb66e View commit details
    Browse the repository at this point in the history

  4. Make the YAML tests happier

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    43da7c8 View commit details
    Browse the repository at this point in the history

  5. Move the form link to make the linter happy

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    8db3542 View commit details
    Browse the repository at this point in the history

  6. Reverse if statement's condition

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    4e49510 View commit details
    Browse the repository at this point in the history

  7. Don't print that form link after the end of month.

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    1b2ae22 View commit details
    Browse the repository at this point in the history

  8. tests: Check only the last output lines

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    a89ede7 View commit details
    Browse the repository at this point in the history

  9. Change {matches -> contains}_expected_lines 

    This also updates invocations that can't be translated as-is into a
different equivalent check.
    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    e4f8e0a View commit details
    Browse the repository at this point in the history

  10. Drop no-longer-used deprecated_python fixture

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    c631de6 View commit details
    Browse the repository at this point in the history

  11. Update test messages to reflect new reality

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    b9ff93f View commit details
    Browse the repository at this point in the history

  12. Moar tests getting updated

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    3962f9d View commit details
    Browse the repository at this point in the history

  13. This counts as a fix right?

    @pradyunsg
    pradyunsg committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    3f88476 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. Python 2 *sigh*

    @pradyunsg
    pradyunsg committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    9033824 View commit details
    Browse the repository at this point in the history