Don't crash on 'check' when METADATA is missing #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Sep 28, 2020
|
Me either (otherwise I’d attach a test). We don’t test the |
uranusjr
force-pushed
the
dont-crash-on-check
branch
from
426b949
to
806c112
Compare
|
Force-merged despite CI failures, since (1) the patch seems very safe, (2) no need to wait for 30+ minutes of CI and (3) reverts are cheap. |
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 12, 2020
Don't crash on 'check' when METADATA is missing
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 12, 2020
Don't crash on 'check' when METADATA is missing
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 12, 2020
Don't crash on 'check' when METADATA is missing
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 12, 2020
Don't crash on 'check' when METADATA is missing
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 16, 2020
Don't crash on 'check' when METADATA is missing
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 16, 2020
Don't crash on 'check' when METADATA is missing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8676.
Ideally I’d want to catch only corruption failure for that specific package and carry on with others, but that does not seem feasible without patching
pkg_resources.Since we already swallow corrupted metadata exceptions, it is probably not a terrible idea to swallow
OSErroranyway. Hopefully theimportlib.metadatamigration would provide a more useful way to handle these errors.