Always reinstall editables #9169
Conversation
Signed-off-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
Signed-off-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
|
(the failing MacOS test is a |
| @@ -178,6 +178,8 @@ def resolve(self, root_reqs, check_supported_wheels): | |||
| gone_in="21.1", | |||
| issue=8711, | |||
| ) | |||
|
|
|||
| # is a local sdist or path -- reinstall | |||
There was a problem hiding this comment.
This case did cover the editable reinstall from local directory. This PR alsos covers editable reinstall of VCS urls 👍
|
I wonder if we should reinstall editable VCS. It has significantly more overhead than local path, and likely depended by less in their development workflow. |
|
(We might eventually decide to always reinstall it, depending on how the discussion in #8711 goes; but I feel it deserves a discussion.) |
|
I totally agree it deserves a discussion. 20.2.4 did reinstall, though, so it's probably good to keep reinstalling for the sake of backward compatibility ? |
|
Yup -- that's the idea here. We can have longer detailed discussions in the future; right now though, we should probably synchronise with 20.2.* behaviour. :) |
|
Thanks for the review @sbidoul! :) |
Closes #9116
As discussed in #9147, we should reinstall editables even if the already installed distribution is editable.