Replace Python 2 tmpdir removal workarounds #9373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Dec 27, 2020
pradyunsg
approved these changes
Dec 27, 2020
pradyunsg
added
the
skip news
hugovk
force-pushed
the
tmpdir_remove
branch
from
e02b82f
to
1ff0924
Compare
pradyunsg
approved these changes
Dec 28, 2020
|
Not sure why macOS/3.7 fails, it's passing on my fork: https://github.com/hugovk/pip/runs/1618886970?check_suite_focus=true |
|
Pytest-xdist + pytest-timeout blow up when used together, due to some race conditions apparently. 🙃 |
|
Anyway, I wouldn't worry about it -- it's not a required job and there's nothing in this change that makes testing 3.7 on MacOS a critical blocker. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8802.
Follow up to #9335, based on suggestions from @jdufresne and @uranusjr in #9335 (comment).