Special case warning for requirements.txt install#9915
Merged
Conversation
uranusjr
requested changes
Apr 30, 2021
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Changed log level of special case warning to info instead of critical.
uranusjr
approved these changes
Apr 30, 2021
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
I think we'll need to wait until 21.1.1 is release. but otherwise LGTM.
Contributor
Author
|
@uranusjr Thanks for the approval, could you run the CI so that everything is set in stone for next release? Thanks. |
Contributor
Author
|
@uranusjr Looks like 21.1.2 is now out, what is the status on this merge? Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a special warning for users who accidentally do
pip install requirements.txtand forget the-rflag.Issue #9908