Exclude a known incompatible installed candidate #9993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resolver collects previously known incompatibilites and sends them to the provider. But previously the provider does not correctly exclude the currently-installed candidate if it is present in that incompatibility list, causing the resolver to enter a loop trying that same candidate. This patch correctly applies incompat_ids when producing an AlreadyInstalledCandidate and exclude it if its id() is in the set.
uranusjr
force-pushed
the
exclude-installed-candidate-if-incompatible
branch
from
e528acf
to
d18ac62
Compare
|
I'd like to do the last 21.1 bugfix release this weekend. Is this one good to go ? |
|
Implementation-wise yes. Let me add a test, it’s better to have one that hangs the entire test suite than none at all. |
|
Done, waiting for CI… |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolver collects previously known incompatibilites and sends them to the provider. But previously the provider does not correctly exclude the currently-installed candidate if it is present in that incompatibility list, causing the resolver to enter a loop trying that same candidate.
This patch correctly applies
incompat_idswhen producing anAlreadyInstalledCandidateto exclude it if itsid()is in the set.I’m hesitant to add a test since it would hang the entire test suite if it fails. Is there a way to set a timeout on a pip call instead?
Fix #9841.