Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exists-action argument passing #2610

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Conversation

techalchemy
Copy link
Member

- Fixes #2326

Signed-off-by: Dan Ryan <dan@danryan.co>
@uranusjr
Copy link
Member

I think we should use keys in this format string now, those indexes are impossible to reason with.

@techalchemy
Copy link
Member Author

What you dont like 3 7 4 8 5 2 6 1 as an order?

@uranusjr
Copy link
Member

Ordering starts from zero obvly?

@uranusjr
Copy link
Member

Ah whatever, this whole thing is a mess and needs a complete rewrite.

@uranusjr uranusjr merged commit 568a9d2 into master Jul 19, 2018
@uranusjr uranusjr deleted the bugfix/2326-exists-action-bug branch July 30, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants