Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra markers doesn't seem to work #3043

Closed
tyilo opened this issue Oct 16, 2018 · 2 comments
Closed

extra markers doesn't seem to work #3043

tyilo opened this issue Oct 16, 2018 · 2 comments
Labels
Type: Duplicate This issue is a duplicate of an already-existing issue.

Comments

@tyilo
Copy link

tyilo commented Oct 16, 2018

Issue description

When installing django-constance using pipenv install "django-constance[database]", it will correctly install the dependency django-picklefield.

However when installing in another venv usingpipenv install, django-picklefield is not installed.

Expected result

pipenv install should install django-picklefield.

Actual result

django-picklefield is not installed. Pipenv gives the warning:

Ignoring django-picklefield: markers 'extra == "database"' don't match your environment

Full install output:

$ pipenv install
Creating a virtualenv for this project…
Pipfile: /tmp/test/Pipfile
Using /usr/bin/python3.7 (3.7.0) to create virtualenv…
⠧Running virtualenv with interpreter /usr/bin/python3.7
Using base prefix '/usr'
/home/tyilo/.local/lib/python3.7/site-packages/virtualenv.py:1041: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
New python executable in /home/tyilo/.local/share/virtualenvs/test-hxkKlP5o/bin/python3.7
Also creating executable in /home/tyilo/.local/share/virtualenvs/test-hxkKlP5o/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /home/tyilo/.local/share/virtualenvs/test-hxkKlP5o
Installing dependencies from Pipfile.lock (eb14ba)…
Ignoring django-picklefield: markers 'extra == "database"' don't match your environment
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 2/2 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.

Steps to replicate

$ mkdir /tmp/pipenv-markers-test
$ cd mkdir /tmp/pipenv-markers-test
$ pipenv install "django-constance[database]"
...
$ pipenv graph
django-constance==2.3.1
django-picklefield==1.1.0

$ pipenv --rm
$ pipenv install
...
$ pipenv graph
django-constance==2.3.1


$ pipenv --support

Pipenv version: '2018.10.13'

Pipenv location: '/home/tyilo/.local/lib/python3.7/site-packages/pipenv'

Python location: '/usr/bin/python'

Python installations found:

  • 3.7.0: /usr/bin/python3.7
  • 3.7.0: /usr/bin/python3.7m
  • 3.5.3: /opt/pypy3/bin/pypy3
  • 2.7.15: /usr/bin/python2.7
  • 2.7.13: /opt/pypy/bin/pypy

PEP 508 Information:

{'implementation_name': 'cpython',
 'implementation_version': '3.7.0',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '4.18.12-arch1-1-ARCH',
 'platform_system': 'Linux',
 'platform_version': '#1 SMP PREEMPT Thu Oct 4 01:01:27 UTC 2018',
 'python_full_version': '3.7.0',
 'python_version': '3.7',
 'sys_platform': 'linux'}

System environment variables:

  • COLORTERM
  • DBUS_SESSION_BUS_ADDRESS
  • DESKTOP_SESSION
  • DISPLAY
  • EDITOR
  • GDMSESSION
  • GDM_LANG
  • GRADLE_HOME
  • GTK_MODULES
  • HG
  • HOME
  • JIF
  • LANG
  • LC_MEASUREMENT
  • LC_PAPER
  • LC_TIME
  • LOGNAME
  • MAIL
  • MOZ_PLUGIN_PATH
  • PATH
  • PWD
  • SHELL
  • SHLVL
  • SMLNJ_HOME
  • TERM
  • THEOS
  • THEOS_DEVICE_IP
  • USER
  • USERNAME
  • VIRTUAL_ENV_DISABLE_PROMPT
  • VTE_VERSION
  • WINDOWID
  • WINDOWPATH
  • XAUTHORITY
  • XDG_RUNTIME_DIR
  • XDG_SEAT
  • XDG_SESSION_DESKTOP
  • XDG_SESSION_ID
  • XDG_SESSION_TYPE
  • XDG_VTNR
  • PYTHONDONTWRITEBYTECODE
  • PIP_SHIMS_BASE_MODULE
  • PIP_PYTHON_PATH

Pipenv–specific environment variables:

Debug–specific environment variables:

  • PATH: /home/tyilo/bin:/home/tyilo/.local/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/smlnj/bin
  • SHELL: /usr/bin/fish
  • EDITOR: vim
  • LANG: en_US.UTF-8
  • PWD: /tmp/pipenv-markers-test

Contents of Pipfile ('/tmp/pipenv-markers-test/Pipfile'):

[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
django-constance = {extras = ["database"], version = "*"}

[dev-packages]

[requires]
python_version = "3.7"

Contents of Pipfile.lock ('/tmp/pipenv-markers-test/Pipfile.lock'):

{
    "_meta": {
        "hash": {
            "sha256": "09ecd4e5fec12bae5d501662725cd95a611ecff1d255d50ffb3a7919c2eb14ba"
        },
        "pipfile-spec": 6,
        "requires": {
            "python_version": "3.7"
        },
        "sources": [
            {
                "name": "pypi",
                "url": "https://pypi.org/simple",
                "verify_ssl": true
            }
        ]
    },
    "default": {
        "django-constance": {
            "extras": [
                "database"
            ],
            "hashes": [
                "sha256:5a4fec5361214b4658c64184b45a6678cb8f8bf8d342f56976f87d5c6645860a",
                "sha256:a49735063b2c30015d2e52a90609ea9798da722ed070f091de51714758a5d018"
            ],
            "index": "pypi",
            "version": "==2.3.1"
        },
        "django-picklefield": {
            "hashes": [
                "sha256:8d1de6be099044ae61e55998b35de18a57499b946fe45781077f5cec4f73f0e0",
                "sha256:ce7fee5c6558fe5dc8924993d994ccde75bb75b91cd82787cbd4c92b95a69f9c"
            ],
            "markers": "extra == 'database'",
            "version": "==1.1.0"
        }
    },
    "develop": {}
}
@frostming
Copy link
Contributor

Replicated here, either 'extra' marker should be ignored when installing, or it shouldn't be produced by resolver.

@techalchemy techalchemy added the Type: Duplicate This issue is a duplicate of an already-existing issue. label Oct 16, 2018
@techalchemy
Copy link
Member

See also: #3026 #3039

tyilo added a commit to fredagscafeen/web that referenced this issue Oct 29, 2020
tyilo added a commit to fredagscafeen/web that referenced this issue Feb 2, 2021
tyilo added a commit to fredagscafeen/web that referenced this issue Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Duplicate This issue is a duplicate of an already-existing issue.
Projects
None yet
Development

No branches or pull requests

3 participants