pipenv lock -r respect pypi_mirror args
#4200
Conversation
techalchemy
added
Category: Dependency Resolution
There was a problem hiding this comment.
Thanks for the pr! I've requested a small change to avoid triggering exceptions for users with multiple indexes declared in their Pipfile, and if you would, please add a news entry (e.g. news/4199.bugfix.rst) with a sentence describing the fix included in the PR, e.g.:
When writing pip-compatible requirements using
pipenv lock -rwhile passing in a--pypi-mirror, the mirror url will now be included instead of the url in thePipfile.
| @@ -791,7 +791,7 @@ def do_install_dependencies( | |||
| skip_lock=False, | |||
| concurrent=True, | |||
| requirements_dir=None, | |||
| pypi_mirror=False, | |||
| pypi_mirror=None, | |||
There was a problem hiding this comment.
This probably shouldn't need to change
There was a problem hiding this comment.
Why the pypi_mirror becoms False default here but None in the rest parts of codes?
There was a problem hiding this comment.
Most likely there is no good reason for this -- and apologies for not taking the time to look at it more closely! If, as you say, this is None everywhere else, and we don't differentiate in the function below (e.g. by checking if it's False) then it will be ok to make this change for consistency
techalchemy
added
PR: awaiting-news
| @@ -791,7 +791,7 @@ def do_install_dependencies( | |||
| skip_lock=False, | |||
| concurrent=True, | |||
| requirements_dir=None, | |||
| pypi_mirror=False, | |||
| pypi_mirror=None, | |||
There was a problem hiding this comment.
Most likely there is no good reason for this -- and apologies for not taking the time to look at it more closely! If, as you say, this is None everywhere else, and we don't differentiate in the function below (e.g. by checking if it's False) then it will be ok to make this change for consistency
techalchemy
removed
the
PR: awaiting-news
Thank you for contributing to Pipenv!
The issue
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
#4199
The fix
How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?
extend the
pip_argsin the first line ofrequirements.txt.The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.