Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore resource warning #6251

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Ignore resource warning #6251

merged 1 commit into from
Sep 23, 2024

Conversation

Naofal-Helal
Copy link
Contributor

@Naofal-Helal Naofal-Helal commented Sep 22, 2024

The issue

When running pipenv install -r requirements.txt, a warning (ResourceWarning: unclosed file) is shown to users.
This warning comes from temporary directories that will be cleared on program exit, and is therefore not meaningful to the user.

The fix

Ignore the warning.

Fixes #6151
Fixes #6155

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@Naofal-Helal Naofal-Helal marked this pull request as ready for review September 22, 2024 11:08
@matteius matteius merged commit f7058e8 into pypa:main Sep 23, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceWarning when pipenv install --python 3.11 -r requirements.txt ResourceWarning: unclosed file
2 participants