moved 'upgrade' and 'upgrade_all' to commands/upgrade.py #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, any feedback about this pull request ? |
|
This looks good besides the merge conflict. |
|
A force push was recently done, so this PR will have to be rebased onto origin/master. Apologies for the inconvenience. See #270. |
ptisserand
force-pushed
the
split-commands
branch
from
b06388b
to
4274144
Compare
|
Hi, I have updated my branch but I don't get it why CI test is now failing. Seems to be related to #266 |
GH pypa#255: break commands.py into individual files. commands: added common.py to remove circular import. Fixed linter issues.
ptisserand
force-pushed
the
split-commands
branch
from
4274144
to
03163d6
Compare
|
I have pushed a rebased version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the first one for issue #255
Only upgrade and upgrade_all commands have been moved in a separate file.