Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unable to execute 'gcc' error when running tests #269

Merged
merged 8 commits into from
Nov 4, 2019

Conversation

itsayellow
Copy link
Contributor

Fixes #266

gcc resides in /usr/bin. Adding /usr/bin to the system path in tests/conftest.py allows gcc to be found if a python library needs to be compiled.

Possibly before all the libraries we needed had wheels, and now some do not have wheels for particular python versions?

@cs01
Copy link
Member

cs01 commented Nov 3, 2019

A force push was recently done, so this PR will have to be rebased onto origin/master. Apologies for the inconvenience. See #270.

@cs01
Copy link
Member

cs01 commented Nov 3, 2019

I attempted to rebase this onto the branch travis_fix. If it looks good you can force push to your branch.

@itsayellow
Copy link
Contributor Author

OK, I think this one rebased properly. Since it was a simpler PR I wanted to try it myself. Let me know if it looks ok.

@itsayellow
Copy link
Contributor Author

A force push was recently done, so this PR will have to be rebased onto origin/master. Apologies for the inconvenience. See #270.

Done--rebased.

Copy link
Member

@cs01 cs01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

travis unix linux builds can't find gcc sometimes
2 participants